[MPlayer-users] OSD problems with DVDs

[Davide Capodaglio]

> > >Please post the patch.
> >
> > Attached osd4.patch (it's against mplayer 1.0-pre7try2).
> > Any feedback is appreciated.
> >
> > >Regards,
> > >R.
> >
> > Bye
> > Davide
> >
> > --- mplayer.c.orig	2005-04-15 14:14:24.000000000 +0200
> > +++ mplayer.c	2005-12-13 09:21:17.171875000 +0100
> > @@ -222,7 +222,8 @@
> >  int enqueue=0;
> >  #endif
> >
> > -#define MAX_OSD_LEVEL 3
> > +//DAVIDE
> > +#define MAX_OSD_LEVEL 4
>
> Please do not comment your additions like this. It's unnecessary and makes
> the code unreadable. Imagine what would happen if every one of many
> MPlayer contributors did this. You will be given proper credit at least
> in CVS logs.
>
> Please resend without these comments.
>
> Regards,
> R.

Ooops sorry, I agree perfectly, I forgot to remove them before sending the 
patch.
Here's the correct one.

Bye
Davide
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osd4.patch
Type: text/x-diff
Size: 1473 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20060119/cae0245e/attachment.patch>