[MPlayer-users] MPlayer-1.0pre8 detecting wrong aspect ratio

[Giacomo Comes]

On Mon, Jul 31, 2006 at 06:40:32PM +0200, Nico Sabbi wrote:
> Giacomo Comes wrote:
> >On Mon, Jul 31, 2006 at 06:08:55PM +0200, Nico Sabbi wrote:
> >  
> >>what I changed in pre8 is the assignment of the A/R code; I moved it 
> >>from the
> >>demuxer domain (where it was totally out of place) to the video decoder 
> >>layer
> >>(where it belongs).
> >>Previously the A/R assignment was completely wrong for mpeg1, because it 
> >>was
> >>assigned as for mpeg2.
> >>    
> >
> >I'm sorry to say but it's the opposite. Previous assignment was correct, 
> >current one is wrong. Not because I have seen the code, just because the
> >previous one was working and the current one is not.
> >  
> 
> no, it's been wrong for ages, but since nobody ever complained the bugs
> passed by unnoticed
> 
> >  
> >>Post some link to samples and we'll see what we can do :)
> >>    
> >
> >You can download MPEG1 samples from:
> >http://www.pcphotovideo.com/VcdSamples.htm
> >
> >or make your own:
> >mencoder <your souce video> -of mpeg -mpegopts vaspect=4/3:format=xvcd 
> >-ovc lavc -lavcopts 
> >vcodec=mpeg1video:vrc_buf_size=327:vrc_minrate=1152:vrc_maxrate=1152:keyint=15:aspect=4/3:vbitrate=1152 -o mpeg1pal.mpg -ofps 25 -vf scale=352:288,harddup -oac lavc -lavcopts acodec=mp2:abitrate=224 -frames 100
> >
> >mencoder <your souce video> -of mpeg -mpegopts vaspect=4/3:format=xvcd 
> >-ovc lavc -lavcopts 
> >vcodec=mpeg1video:vrc_buf_size=327:vrc_minrate=1152:vrc_maxrate=1152:keyint=18:aspect=4/3:vbitrate=1152 -o mpeg1ntsc.mpg -ofps 30000/1001 -vf scale=352:240,harddup -oac lavc -lavcopts acodec=mp2:abitrate=224 -frames 100
> >
> >Giacomo
> >  
> 
> in this case  lavc is buggy in this respect.
> The assignment of A/R for mpeg1video is quite complicated and totally 
> different from
> the corresponding code for mpeg2video

I know that. And I also sayd that I didn't see the code. The fact is that even
if your current code is correct, your change alone has introduced a bug in
mplayer. 
If it is your code that need to be changed or it is lavc that needs to be 
fixed I don't know. But currently the bug is there and my task was to report it.

Giacomo