[MPlayer-users] no display of VOB subtitle streams

[Reimar Döffinger]

Hello,
an ancient bug report, but still...

On Mon, Jan 19, 2009 at 10:53:32AM +0100, Alexander Roalter wrote:
> Adam Seychell wrote:
> > After two weeks of trying to build mplayer under cygwin , I still cannot 
> > get embedded subtitles in VOB files. The OSD font is working as I can 
> > see text when activating various control buttons like volume delay, et.
> > mplayer was compiled with freetype and fontconfig libraries and 
> > subfont.tff is successfully found.
> > 
> > I tested an outdated windows binary version of mplayer:
> > http://www.mplayerhq.hu/MPlayer/releases/win32/MPlayer-mingw32-1.0rc2.zip
> > and when playing the same VOB file and -sid numbers I can see the subtitles.

I think this is fixed with r29095

> Only one drawback remains: if I select -forcedsubsonly at the beginning,
> this is not considered: I have to press Shift+F twice, to get
> forced-only subtitles. Some patch would be needed for this, too.

I don't have any files with forced subs at hand, so I'd be happy if
someone could try attached patch, preferably also with mencoder...
-------------- next part --------------
Index: mplayer.c
===================================================================
--- mplayer.c	(revision 29086)
+++ mplayer.c	(working copy)
@@ -1125,8 +1125,10 @@
     spudec_set_font_factor(vo_spudec,font_factor);
   }
 
-  if (vo_spudec!=NULL)
+  if (vo_spudec!=NULL) {
     initialized_flags|=INITIALIZED_SPUDEC;
+    mp_property_do("sub_forced_only", M_PROPERTY_SET, &forced_subs_only, mpctx);
+  }
 }
 
 /*
@@ -3066,6 +3068,7 @@
     if(vo_vobsub){
       initialized_flags|=INITIALIZED_VOBSUB;
       vobsub_set_from_lang(vo_vobsub, dvdsub_lang);
+      mp_property_do("sub_forced_only", M_PROPERTY_SET, &forced_subs_only, mpctx);
 
       // setup global sub numbering
       mpctx->global_sub_indices[SUB_SOURCE_VOBSUB] = mpctx->global_sub_size; // the global # of the first vobsub.
Index: mencoder.c
===================================================================
--- mencoder.c	(revision 29086)
+++ mencoder.c	(working copy)
@@ -698,6 +698,8 @@
                            sh_video->disp_w, sh_video->disp_h, NULL, 0);
 }
 #endif
+if (vo_spudec)
+  spudec_set_forced_subs_only(vo_spudec, forced_subs_only);
 }
 
 ostream = open_output_stream(out_filename, 0);