[MPlayer-users] Mplayer crashes when adjusting contrast to the lowest value

[Reimar Döffinger]

On Sat, Jan 30, 2010 at 11:02:43PM +0100, Giorgio wrote:
> I've noticed that when I play a file or watch tv using -vo gl, if I
> press the '1' key and
> keep it pressed until the image goes dark and the cursor on the OSD
> move to its lowest
> value, MPlayer crashes. Example:

Two solutions:
1) Let OpenGL do it, use e.g. -vo gl:yuv=2
2) Try this patch:
Index: yuv2rgb.c
===================================================================
--- yuv2rgb.c	(revision 30453)
+++ yuv2rgb.c	(working copy)
@@ -629,10 +629,12 @@
     oy -= 256*brightness;
 
     //scale coefficients by cy
+    cy++;
     crv = ((crv << 16) + 0x8000) / cy;
     cbu = ((cbu << 16) + 0x8000) / cy;
     cgu = ((cgu << 16) + 0x8000) / cy;
     cgv = ((cgv << 16) + 0x8000) / cy;
+    cy--;
 
     av_free(c->yuvTable);