[MPlayer-users] RTP streaming and cache problem

[Reimar Döffinger]

On 26 Mar 2011, at 21:25, "Tibor Simko" <tibsi1 at gmail.com> wrote:
>> On Sat, Mar 26, 2011 at 08:32:51PM +0100, Reimar Döffinger wrote:
>> > On Fri, Mar 25, 2011 at 09:10:40AM +0100, Tibor S wrote:
>> > > When I start RTP streaming it works fine for several seconds, then
>> > > "RTP buffer invalid; no data return from network" message appears.
>> >
>> > That message should not cause any issues.
>> > What is the actual problem?
>> 
>> Ok, saw it. I think I fixed it, but did not have any rtp server around
>> to test.
> 
> How did you fix it?

There is only one case where it can go wrong: when wrapping around from the end of the cache to the beginning.
If necessary, the code now in this case reads into the stream buffer and copies over to the cache afterwards.
This is most what stream_read does, too, but stream_read would always copy which costs performance and it can't read more than 2kB at once which costs massive performance over WLAN for protocols like SMB where the kernel does not (properly?) do read-ahead.

> Will the fix be included in the morning source snapshot?

Probably. A direct SVN checkout would certainly work. With that you can also use svn diff to check the change yourself.