[MPlayer-users] [PATCH][RFT] Compile error on ARM

[Erik Auerswald]

Hi,

On 12/20/2012 09:11 PM, Oliver Seitz wrote:
> On 20.12.2012 20:24, Erik Auerswald wrote:
>> #define HAVE_VFP 1
>
> Thank you, this makes it go on compiling :-)
>
> There are some VFP related defines already:
>
> $ grep -i vfp config.h
> #define HAVE_VFP_ARGS 1
> #define HAVE_ARMVFP 1
> #define HAVE_VFPV3 0
> #define HAVE_ARMVFP_EXTERNAL 1
> #define HAVE_VFPV3_EXTERNAL 0
> #define HAVE_ARMVFP_INLINE 1
> #define HAVE_VFPV3_INLINE 0
>
> Could it be that the flag is present, but its name is wrong?

Possible. That is the same feature may have differently named #defines 
in MPlayer and FFmpeg. HAVE_ARMVFP sounds very like HAVE_VFP inside an 
ARM scope.

You could compare the configure checks for these features with the VFP 
check in ffmpeg/configure to form an opinion on this. If one of the 
tests is for the same feature, you could add the HAVE_VFP define to this 
test.

Could you test the attached patch? It is an attempt to add the VFP name 
to the ARMVFP check.

MPlayer still builds with this on x86, without detecting the ARM CPU 
features ;-):

$ fgrep VFP config.h
#define HAVE_ARMVFP 0
#define HAVE_VFP 0
#define HAVE_VFPV3 0
#define HAVE_ARMVFP_EXTERNAL 0
#define HAVE_VFP_EXTERNAL 0
#define HAVE_VFPV3_EXTERNAL 0
#define HAVE_ARMVFP_INLINE 0
#define HAVE_VFP_INLINE 0
#define HAVE_VFPV3_INLINE 0

Regards,
Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-configure-arm_VFP.shot_in_the_dark.patch
Type: text/x-diff
Size: 1180 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20121220/ad454c25/attachment.bin>