[MPlayer-users] Playing DASH streams / .mpd files

[The Wanderer]

On 2021-03-19 at 08:10, Ingo Brückl wrote:

> Reimar Döffinger wrote on Thu, 18 Mar 2021 19:32:20 +0100:
> 
>> Looks good to me, at most I would suggest that maybe instead of
>> "requires internal FFmpeg" it might be more accurate to say "only used
>> for internal FFmpeg" or "not used/needed for shared FFmpeg" or so?
> 
> We are already using suitable messages for such cases:
> 
> -        res_comment="requires internal FFmpeg"
> +        test "$ffmpeg_a" = no && res_comment="dynamic linking to libxml2 is irrelevant when using dynamic FFmpeg"

This statement conveys (at least to me) the implication that with
dynamic FFmpeg, DASH support will come automatically if the dynamic
FFmpeg copy being used was compiled with that support. Is that accurate?

I was originally going to call the test unnecessary, because this
assignment is already inside the else clause of an 'if test "$ffmpeg_a"
= yes'. However, on re-examining I notice that that if block actually
tests two conditions, only one of which is related to internal vs.
external FFmpeg, so I think I approve of that part of the change.

The suggested phrasing seems overly lengthy and verbose to me, but it
does reflect an established usage, and this is one instance where I
don't expect to bikeshed over it.

> I also suggest:
> 
> -int main() {
> +int main(void) {

Sure, no objections. It's a few more bytes, but strictly more compliant,
and matches the established pattern now that I look for one.

Should I respin and resubmit the patch, once the above question is
addressed, or are people OK with making these changes independently of
me?

-- 
   The Wanderer

The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all
progress depends on the unreasonable man.         -- George Bernard Shaw

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.mplayerhq.hu/pipermail/mplayer-users/attachments/20210319/6db1deee/attachment.sig>