[NUT-devel] Spec bug with index

Oded Shimon ods15 at ods15.dyndns.org
Mon Feb 13 08:07:57 CET 2006


Heh, I didn't expect any problems when implementing EOR, good thing I did, 
I found a bug in the spec:

            for(; j<n && j<syncpoints; j++){
                if (!has_keyframe[j][i]) continue
                A                           v
                if(!A){
                    A                       v
                    B                       v
                    eor_pts[j][i] = last_pts + A + B
                }else
                    B=0
                keyframe_pts[j][i] = last_pts + A
                last_pts += A + B
            }

last_pts is implicitly inited to zero. The first key_pts in the file really 
have a pts of zero, so 'A' needs to be zero, and still not be EOR. This 
patch fixes this...

On another note, the 'prefix' (mpeg-4/mp3 startcode) is officially off the 
table?

- ods15
-------------- next part --------------
Index: DOCS/tech/mpcf.txt
===================================================================
RCS file: /cvsroot/mplayer/main/DOCS/tech/mpcf.txt,v
retrieving revision 1.104
diff -u -r1.104 mpcf.txt
--- DOCS/tech/mpcf.txt	12 Feb 2006 17:40:02 -0000	1.104
+++ DOCS/tech/mpcf.txt	13 Feb 2006 06:58:40 -0000
@@ -238,6 +238,7 @@
         syncpoint_pos_div8              v
     }
     for(i=0; i<stream_count; i++){
+        last_pts= -1
         for(j=0; j<syncpoints; ){
             x                           v
             type= x & 1


More information about the NUT-devel mailing list