[NUT-devel] Patch for info packets

[Michael Niedermayer]

Hi

On Tue, Feb 21, 2006 at 01:11:30PM +0200, Oded Shimon wrote:
> This is my patch... Comments welcome, I hope this patch will please 
> everyone...
> 
> - ods15

> Index: DOCS/tech/mpcf.txt
> ===================================================================
> RCS file: /cvsroot/mplayer/main/DOCS/tech/mpcf.txt,v
> retrieving revision 1.108
> diff -u -r1.108 mpcf.txt
> --- DOCS/tech/mpcf.txt	20 Feb 2006 04:49:06 -0000	1.108
> +++ DOCS/tech/mpcf.txt	21 Feb 2006 11:10:19 -0000
> @@ -262,21 +262,33 @@
>      checksum                            u(32)
>  
>  info_frame: (optional)
> -    for(;;){
> -        id                              v
> -        if(id==0) break
> -        name= info_table[id][0]
> -        type= info_table[id][1]
> -        if(type==NULL)
> +    stream_id_plus1                     v
> +    chapter_id                          v
> +    if (chapter_id) {
> +        chapter_start                   v
> +        if (chapter_id < 0)
> +            chapter_len                 v

i would prefer of chapter_len is always coded when chapte_start is
theres also the question of the length of the last chapter ...



> +    }
> +    count                               v
> +    for(i=0; i<count; i++){
> +        name                            vb
> +        value                           s
> +        if (value==-1){
> +            type= "UTF-8"
> +            value                       vb
> +        }else if (value==-2){
>              type                        vb
> -        if(name==NULL)
> -            name                        vb
> -        if(type=="v")
> -            value                       v
> -        else if(type=="s")
> -            value                       s
> -        else
>              value                       vb
> +        }else if (value==-3){
> +            type= "signed integer"
> +            value                       s
> +        }else if (value<-3){
> +            type= "rational"
> +            value.den= -value-2
> +            value.num                   s

what advantage is there in the seperate "signed integer"?



[...]
> +chapter_start
> +    s= chapter_start % stream_count
> +    timestamp= chapter_start / stream_count
> +    timestamp of start of chapter in timebase of stream 's'.
> +    Positive chapter_id's MUST be in sequential order.

IMHO chapter_start should be in the timebase of stream s if the info packet
applies just to that stream


[...]
>          image of the (CD, DVD, VHS, ..) cover (preferably PNG or JPEG)
>      "Source"
>          "DVD", "VCD", "CD", "MD", "FM radio", "VHS", "TV", "LD"
> @@ -640,8 +666,6 @@
>          (ISO 8601 format, see http://www.cl.cam.ac.uk/~mgk25/iso-time.html)
>          Note: do not forget the timezone
>      "Keywords"
> -    "TotalTime"
> -        total length of the stream in msecs

hmmmmm, global info packets dont have chapter_len, index is optional and
you remove this umm ...

[...]
-- 
Michael