[NUT-devel] Suggestions [PATCH]

[Michael Niedermayer]

Hi

On Sun, Mar 05, 2006 at 09:19:34AM +0200, Oded Shimon wrote:
> On Wed, Mar 01, 2006 at 06:15:44AM +0200, Oded Shimon wrote:
> > On Tue, Feb 28, 2006 at 10:34:22PM +0100, Michael Niedermayer wrote:
> > > +note, demuxers MUST be able to deal with new and unknown headers
> > 
> > One thing about this, what if the forward_ptr of this unkown header is 
> > 100mb and you just lost half the file... Oh, just noticed, even new headers 
> > have checksums, ok then...
> 
> Actually, I still have an issue with this... By a single byte of damage 
> ('N') you can cause either the player to skip the entire file, or to have 
> to cache arbitrary amount of MB of the file, or to seek back.. Am I missing 
> something here? (You have to read all the data at least once to see that 
> the checksum is bogus, and by then you have either skipped 700mb or you you 
> cached it)

add a checksum which just covers startcode + forward ptr if forward_ptr 
is > 64k or dissalow arbitrary sized packets (=split index, info and 
stream headers)

i also vote again for droping the variable checksum size threshold for 
frame headers and fixing it to something like 64k ...

[...]
-- 
Michael