[NUT-devel] [nut]: r545 - src/trunk/nututils/nutparse.c

Rich Felker dalias at aerifal.cx
Sat Feb 2 20:09:35 CET 2008


On Sat, Feb 02, 2008 at 01:07:54PM +0100, ods15 wrote:
> Author: ods15
> Date: Sat Feb  2 13:07:53 2008
> New Revision: 545
> 
> Log:
> Warning fixes to nutparse.c
> 
> 
> Modified:
>    src/trunk/nututils/nutparse.c
> 
> Modified: src/trunk/nututils/nutparse.c
> ==============================================================================
> --- src/trunk/nututils/nutparse.c	(original)
> +++ src/trunk/nututils/nutparse.c	Sat Feb  2 13:07:53 2008
> @@ -182,11 +182,6 @@ static int64_t read_svar(void)
>  	return convert_to_signed(read_var());
>  }
>  
> -static int64_t read_svar_restricted(void)
> -{
> -	return convert_to_signed(read_var_restricted());
> -}
> -
>  static uint64_t convert_ts(uint64_t t, int tb_from, int tb_to)
>  {
>  	uint64_t ln = time_bases[tb_from].num * time_bases[tb_to].denom;
> @@ -451,7 +446,7 @@ static void parse_stream_header(void)
>  		if (value && gcd(value, value2) != 1)
>  			error("sample_width/height must be relatively prime");
>  		printf("  colorspace_type: %"PRIu64"\n", read_var());
> -	} else if (class = 1) {
> +	} else if (class == 1) {

THIS IS NOT A WARNING FIX BUT A FUNCTIONAL CHANGE! (Most likely a
bugfix but either that or a new bug :)

Some of the 0 initializations looked suspicious too. Why are those
variables never initialized correctly before later use??

Rich



More information about the NUT-devel mailing list