[FFmpeg-cvslog] r10032 - trunk/libavformat/nutenc.c

[ods15 at ods15.dyndns.org]

On Sat, Aug 11, 2007 at 12:08:17PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Sat, Aug 11, 2007 at 11:23:45AM +0200, Tom?? Janou?ek wrote:
> > Hi,
> > 
> > On Sat, Aug 11, 2007 at 10:34:46AM +0300, ods15 at ods15.dyndns.org wrote:
> > > On Thu, Aug 09, 2007 at 11:01:22PM +0200, michael wrote:
> > > > +        if(flags & FLAG_CODED){
> > > > +            length++;
> > > > +            flags &= ~needed_flags;
> > > > +            flags |=  needed_flags;
> > > > +        }
> > > 
> > > Isn't this simply.. flags = needed_flags; ?..
> > 
> > flags |= needed_flags; actually.
> 
> fixed

I think your fix made it worse...

The previous code was correct, just a little silly/redundant (a simple 
'flags = needed_flags;' would be the same and correct)

The new code only does 'flags |=  needed_flags', which is incorrect
(for example, if FLAG_SIZE_MSB is set in 'flags', but it is not needed..)

- ods15