[FFmpeg-cvslog] r10032 - trunk/libavformat/nutenc.c

[Michael Niedermayer]

Hi

On Sat, Aug 11, 2007 at 01:17:37PM +0300, ods15 at ods15.dyndns.org wrote:
> On Sat, Aug 11, 2007 at 12:08:17PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Sat, Aug 11, 2007 at 11:23:45AM +0200, Tom?? Janou?ek wrote:
> > > Hi,
> > > 
> > > On Sat, Aug 11, 2007 at 10:34:46AM +0300, ods15 at ods15.dyndns.org wrote:
> > > > On Thu, Aug 09, 2007 at 11:01:22PM +0200, michael wrote:
> > > > > +        if(flags & FLAG_CODED){
> > > > > +            length++;
> > > > > +            flags &= ~needed_flags;
> > > > > +            flags |=  needed_flags;
> > > > > +        }
> > > > 
> > > > Isn't this simply.. flags = needed_flags; ?..
> > > 
> > > flags |= needed_flags; actually.
> > 
> > fixed
> 
> I think your fix made it worse...

no it does the same


> 
> The previous code was correct, just a little silly/redundant (a simple 
> 'flags = needed_flags;' would be the same and correct)

they all are correct as they all do the same


> 
> The new code only does 'flags |=  needed_flags', which is incorrect
> (for example, if FLAG_SIZE_MSB is set in 'flags', but it is not needed..)

such a case does not exist, and the original would have been affected too


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070811/8ce5536d/attachment.pgp>