[FFmpeg-cvslog] r9596 - in trunk: configure libavcodec/utils.c

Ramiro Ribeiro Polla ramiro
Wed Jul 11 17:18:00 CEST 2007


Attila Kinali wrote:
> On Wed, 11 Jul 2007 15:57:23 +0200 (CEST)
> ramiro <subversion at mplayerhq.hu> wrote:
>
>   
>> -#ifdef __MINGW32__
>> +#if !defined(HAVE_MKSTEMP)
>>      fd = open(*filename, _O_RDWR | _O_BINARY | _O_CREAT, 0444);
>>  #else
>>     
>
> This breaks compilation on unices. O_RDWR & Co are defined without the
> preceding underscore. And AFAIK O_BINARY is not defined at all.
>
>   

Hmm... It sure builds fine here. It should be ifdef'd out if mkstemp() 
exists on the system. Is configure picking up mkstemp() correctly on 
your system?

Anyways, I'll loose the underscores (which are now unneeded for MinGW) 
and do the same O_BINARY checking as in file.c

Ramiro Polla




More information about the ffmpeg-cvslog mailing list