[FFmpeg-cvslog] r9596 - in trunk: configure libavcodec/utils.c

[Ramiro Ribeiro Polla]

Ramiro Ribeiro Polla wrote:
> Attila Kinali wrote:
>   
>> On Wed, 11 Jul 2007 15:57:23 +0200 (CEST)
>> ramiro <subversion at mplayerhq.hu> wrote:
>>
>>   
>>     
>>> -#ifdef __MINGW32__
>>> +#if !defined(HAVE_MKSTEMP)
>>>      fd = open(*filename, _O_RDWR | _O_BINARY | _O_CREAT, 0444);
>>>  #else
>>>     
>>>       
>> This breaks compilation on unices. O_RDWR & Co are defined without the
>> preceding underscore. And AFAIK O_BINARY is not defined at all.
>>
>>   
>>     
>
> Hmm... It sure builds fine here. It should be ifdef'd out if mkstemp() 
> exists on the system. Is configure picking up mkstemp() correctly on 
> your system?
>
>   

Now that I thought more about it, you need to reconfigure. Did you 
re-run configure?

> Anyways, I'll loose the underscores (which are now unneeded for MinGW) 
> and do the same O_BINARY checking as in file.c
>
>   

I hope it was ok to remove the underscores (it was pretty trivial), so I 
did that part.

Ok to apply attached patch?

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: o_binary.diff
Type: text/x-patch
Size: 770 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070711/b24c3e8a/attachment.bin>