[Ffmpeg-devel] how about using posix_memalign?

[Måns Rullgård]

"Ronald S. Bultje" <rbultje at ronald.bitfreak.net> writes:

> Hi,
>
> On Mon, 11 Apr 2005, Wolfram Gloger wrote:
>> > Free() on memalign'ed memory gives problems at least on Linux, see the
>> > GNOME bugzilla report in my original email.
>>
>> That was with valgrind only, AFAICS.  free() on memalign()ed memory
>> works just fine on Linux, at least since 1995 and probably even
>> before.
>
> That's fine, since I use valgrind a lot (for me, it's a cheap and
> acceptable memory/call profiler and memory debugger). Anyway, I don't care
> enough; disregard the patch if you don't care about this.
>
> The automatic next step is that ffmpeg has never been valgrinded; that
> worries me a bit.

$ valgrind ffmpeg -i foo.mpg -vcodec rawvideo -f rawvideo -y /dev/null
==23199== Memcheck, a memory error detector for x86-linux.
==23199== Copyright (C) 2002-2004, and GNU GPL'd, by Julian Seward et al.
==23199== Using valgrind-2.2.0, a program supervision framework for x86-linux.
==23199== Copyright (C) 2000-2004, and GNU GPL'd, by Julian Seward et al.
==23199== For more details, rerun with: -v
==23199== 
ffmpeg version 0.4.9-pre1, build 4752, Copyright (c) 2000-2004 Fabrice Bellard
  configuration:  --prefix=/home/mru/opt/ffmpeg/default --tune=pentium4 --disable-strip --enable-shared --enable-gpl --enable-mp3lame --enable-faad --enable-faac --enable-a52 --enable-dts --enable-vorbis --enable-ogg --enable-x264 
  built on Apr  7 2005 17:10:38, gcc: 3.3.5  (Gentoo Linux 3.3.5-r1, ssp-3.3.2-3, pie-8.7.7.1)
Input #0, mpeg, from 'foo.mpg':
  Duration: 00:04:22.7, start: 5228.128811, bitrate: 5153 kb/s
  Stream #0.0: Video: mpeg2video, 704x480, 29.97 fps, 4750 kb/s
  Stream #0.1: Audio: mp2, 48000 Hz, stereo, 384 kb/s
Output #0, rawvideo, to '/dev/null':
  Stream #0.0: Video: rawvideo, yuv420p, 704x480, 29.97 fps, q=2-31, 200 kb/s
Stream mapping:
  Stream #0.0 -> #0.0
Press [q] to stop encoding
frame=  118 q=0.0 Lsize=   58410kB time=3.9 bitrate=121529.7kbits/s    s/s    
video:50985kB audio:0kB global headers:0kB muxing overhead 14.563107%
==23199== 
==23199== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 35 from 1)
==23199== malloc/free: in use at exit: 0 bytes in 0 blocks.
==23199== malloc/free: 917 allocs, 917 frees, 67162204 bytes allocated.
==23199== For a detailed leak analysis,  rerun with: --leak-check=yes
==23199== For counts of detected errors, rerun with: -v

Happy now?

-- 
M?ns Rullg?rd
mru at inprovide.com