[Ffmpeg-devel] x264, Windows and u_char in x264.c

[Måns Rullgård]

"Matthew Dippel" <johngalt at acousticiris.com> writes:

> Hi,
>
> 	Preface: Me < C Novice. (and worse yet, running Windows [at
> least as far as ffmpeg is concerned])
> 	Of course, problem: ffMpeg wouldn't compile in Windows with x264
> enabled.  The issue appears to be that there are two references to a
> type "u_char" in x264.c. (Compiler Error Output below)
> 	Googled that error and found a reference to a solution from
> another project which resulted in me replacing the two occurrences of
> u_char in x264.c with uint8_t.  I was able to successfully compile and
> encode a test MPEG2 file to h264.
>
> 	I apologize for not just providing a patch, but I don't know how
> to do it, and on top of it all, I don't know what the ramifications of
> changing these types are as a whole.  My hope is that a *real* C
> developer could determine if this is acceptable or not...if it is, I'll
> provide a patch that does exactly this below (as soon as I figure out
> how the hell to use diff and provide it in such a way that does cause
> others to flood the mailing list with angry posts):

Fixed.  Thanks for reporting.

-- 
M?ns Rullg?rd
mru at inprovide.com