[Ffmpeg-devel] x264, Windows and u_char in x264.c

[Michel Bardiaux]

M?ns Rullg?rd wrote:
> "Matthew Dippel" <johngalt at acousticiris.com> writes:
> 
> 
>>Hi,
>>
>>	Preface: Me < C Novice. (and worse yet, running Windows [at
>>least as far as ffmpeg is concerned])
>>	Of course, problem: ffMpeg wouldn't compile in Windows with x264
>>enabled.  The issue appears to be that there are two references to a
>>type "u_char" in x264.c. (Compiler Error Output below)
>>	Googled that error and found a reference to a solution from
>>another project which resulted in me replacing the two occurrences of
>>u_char in x264.c with uint8_t.  I was able to successfully compile and
>>encode a test MPEG2 file to h264.
>>
>>	I apologize for not just providing a patch, but I don't know how
>>to do it, and on top of it all, I don't know what the ramifications of
>>changing these types are as a whole.  My hope is that a *real* C
>>developer could determine if this is acceptable or not...if it is, I'll
>>provide a patch that does exactly this below (as soon as I figure out
>>how the hell to use diff and provide it 

Rather easy, actually, if you have a checked-out tree where the only 
modifs are the ones you want to make into a patch. Do a final cvs 
update, just to make sure. Then, from the top:

cvs diff -du .

How you catch the output depends on the shell and tools you use. In MSYS:

cvs diff -du . > my.pat

In WINCVS you would type the command at the bottom of the workspace 
(bottom window of the main window) and copy/paste.

Then post the file of the devel list as attachment to a message with 
[PATCH] and a very short description in the subject, and whatever 
additional rationales may be necessary.

Its a bit more complicated when the patch involves a NEW file, I admit I 
havent mastered that yet.

>in such a way that does cause
>>others to flood the mailing list with angry posts):
> 
> 
> Fixed.  Thanks for reporting.
> 

HaND,
-- 
Michel Bardiaux
Peaktime Belgium S.A.  Bd. du Souverain, 191  B-1160 Bruxelles
Tel : +32 2 790.29.41