[Ffmpeg-devel] [PATCH] from DivX, Part 11: Matroska features

[Michael Niedermayer]

Hi

On Fri, Dec 16, 2005 at 03:35:39PM -1000, Steve Lhomme wrote:
> This patch add 3 features to matroska :
> - HE-AAC support with full sampling frenquency
> - aspect-ratio
> - FPS when available (informational but can be useful)
> 
> The clean types patch also added a fix for a variable, and the bitstream 
> patch has a fix for a value that was considered as an error an is not.

[...]
> +static aac_sampling_frequencies[] = {
> +    96000, 88200, 64000, 48000, 44100, 32000, 24000, 22050,
> +    16000, 12000, 11025,  8000,     0,     0,     0,     0 };
> +

duplicate code (this is at least in faad.c)


[...]
> +                    char *b;
> +                        for (SRI=0; SRI<sizeof(aac_sampling_frequencies); SRI++)
> +                            if (aac_sampling_frequencies[SRI] == ((MatroskaAudioTrack *)track)->internal_samplerate)
> +                                break;
> +                    extradata_size = 2;

messed up indention


[...]
> +            if (track->default_duration)
> +                av_reduce(&st->codec->time_base.num, &st->codec->time_base.den, track->default_duration, 1000000000, 120);

av_set_pts_info() should be enough


[...]

-- 
Michael