[Ffmpeg-devel] [PATCH] from DivX, Part 11: Matroska features

[Steve Lhomme]

Michael Niedermayer wrote:
> Hi
> 
> On Fri, Dec 16, 2005 at 03:35:39PM -1000, Steve Lhomme wrote:
> 
>>This patch add 3 features to matroska :
>>- HE-AAC support with full sampling frenquency
>>- aspect-ratio
>>- FPS when available (informational but can be useful)
>>
>>The clean types patch also added a fix for a variable, and the bitstream 
>>patch has a fix for a value that was considered as an error an is not.
> 
> 
> [...]
> 
>>+static aac_sampling_frequencies[] = {
>>+    96000, 88200, 64000, 48000, 44100, 32000, 24000, 22050,
>>+    16000, 12000, 11025,  8000,     0,     0,     0,     0 };
>>+
> 
> 
> duplicate code (this is at least in faad.c)

Which is only available in the GPL mode. So either that code is moved in 
an independant place, or the code duplication is logical.