[Ffmpeg-devel] [PATCH] make dvdsub encoder depend on config variables

[Wolfram Gloger]

Hi,

> +ifeq ($(CONFIG_DVBSUB_DECODER)$(CONFIG_DVBSUB_ENCODER),)
> +   OBJS+= dvbsub.o
> +endif

This should be if_n_eq, no?

> +ifeq ($(CONFIG_DVDSUB_DECODER),yes)
> +   OBJS+= dvdsub.o
> +endif
> +ifeq ($(CONFIG_DVDSUB_DECODER)$(CONFIG_DVDSUB_ENCODER),)
> +   OBJS+= dvdsubenc.o
> +endif

Also here:  perhaps use if_n_eq; but IIRC the dvdsub encoder
is totally independent from the dvdsub decoder, so why not use:

ifeq ($(CONFIG_DVDSUB_ENCODER),yes)
...

Rest looks Ok to me.

Regards,
Wolfram.