[Ffmpeg-devel] [PATCH] make dvdsub encoder depend on config variables

[Diego Biurrun]

On Mon, Nov 21, 2005 at 08:39:45AM +0000, Wolfram Gloger wrote:
> 
> > +ifeq ($(CONFIG_DVBSUB_DECODER)$(CONFIG_DVBSUB_ENCODER),)
> > +   OBJS+= dvbsub.o
> > +endif
> 
> This should be if_n_eq, no?

Huh?  It's supposed to be compiled-in only when those two defines are
set in config.mak ...

> > +ifeq ($(CONFIG_DVDSUB_DECODER),yes)
> > +   OBJS+= dvdsub.o
> > +endif
> > +ifeq ($(CONFIG_DVDSUB_DECODER)$(CONFIG_DVDSUB_ENCODER),)
> > +   OBJS+= dvdsubenc.o
> > +endif
> 
> Also here:  perhaps use if_n_eq;

Also here: Huh?

> but IIRC the dvdsub encoder is totally independent from the dvdsub
> decoder, so why not use:
> 
> ifeq ($(CONFIG_DVDSUB_ENCODER),yes)

OK

Diego