[Ffmpeg-devel] [RFC] ZMBV encoder
Michael Niedermayer
michaelni
Tue Dec 5 18:32:50 CET 2006
Hi
On Tue, Dec 05, 2006 at 05:11:35PM +0100, Benjamin Larsson wrote:
> Michael Niedermayer skrev:
> [..]
>
> >>+#ifdef CONFIG_ZLIB
> >>+ // Needed if zlib unused or init aborted before deflateInit
> >>+ memset(&(c->zstream), 0, sizeof(z_stream));
> >>+#else
> >>+ av_log(avctx, AV_LOG_ERROR, "Zlib support not compiled.\n");
> >>+ return 1;
> >>+#endif
> >
> >hmm maybe the whole file shouldnt be compiled if zlib isnt available
> >
> >except these patch ok
> >
> >[...]
> >
>
> Hi, can we get a policy for this? Currently we have both disabled
> compilation and runtime reporting like this.
yes, theres no sense to compile a codec which then cannot work but just
says "oops" ...
> And maybe we should get a
> native zlib implementation ?
yes if its nice, clean simple and small (<=300 lines of code)
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you really think that XML is the answer, then you definitly missunderstood
the question -- Attila Kinali
More information about the ffmpeg-devel
mailing list