[Ffmpeg-devel] [RFC] ZMBV encoder

[Diego Biurrun]

On Tue, Dec 05, 2006 at 06:32:50PM +0100, Michael Niedermayer wrote:
> 
> On Tue, Dec 05, 2006 at 05:11:35PM +0100, Benjamin Larsson wrote:
> > Michael Niedermayer skrev:
> > [..]
> > 
> > >>+#ifdef CONFIG_ZLIB
> > >>+    // Needed if zlib unused or init aborted before deflateInit
> > >>+    memset(&(c->zstream), 0, sizeof(z_stream));
> > >>+#else
> > >>+    av_log(avctx, AV_LOG_ERROR, "Zlib support not compiled.\n");
> > >>+    return 1;
> > >>+#endif
> > >
> > >hmm maybe the whole file shouldnt be compiled if zlib isnt available
> > 
> > Hi, can we get a policy for this? Currently we have both disabled 
> > compilation and runtime reporting like this.
> 
> yes, theres no sense to compile a codec which then cannot work but just
> says "oops" ...

Agreed.  IMO we should disable codecs that need zlib when zlib is not
available.

Diego