[Ffmpeg-devel] swscale patch

[Diego Biurrun]

On Tue, Jul 04, 2006 at 01:17:47PM +0200, Luca Abeni wrote:
> 
> while addressing Michael's comments, I also split swscale.diff in 3
> pieces:
> - the first one just changes libswscale's Makefile making it similar to
> the libav* makefiles

> --- mplayer.orig/libswscale/Makefile	2006-07-04 11:03:37.000000000 +0200
> +++ mplayer/libswscale/Makefile	2006-07-04 11:05:14.000000000 +0200
> @@ -1,52 +1,22 @@
> -
> +#
> +# libswscale Makefile
> +#

Hmm, not strictly necessary, some of the libav* Makefiles have it, some
don't.  I'd leave it out as redundant, but I don't really care.

> +# NOTE: -I.. is needed to include config.h
> +CFLAGS=$(OPTFLAGS) -I.. -I$(SRC_PATH) -I$(SRC_PATH)/libavutil -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
 
Please break this long line into a few more manageable pieces.

> +NAME=swscale
> +ifeq ($(BUILD_SHARED),yes)
> +LIBVERSION=$(LAVUVERSION)
> +LIBMAJOR=$(LAVUMAJOR)
>  endif

Please move this to the top of the Makefile, I prefer it to be there.
Yes, this is inconsistent among the other Makefiles, maybe I'll change
it later on.  Also, there should be a proper version for libswscale,
right now you are just hijacking the version from libavutil.

Diego