[Ffmpeg-devel] swscale patch

[Luca Abeni]

Hi Diego,

On Wed, 2006-07-05 at 16:30 +0200, Diego Biurrun wrote:
[...]
> > --- mplayer.orig/libswscale/Makefile	2006-07-04 11:03:37.000000000 +0200
> > +++ mplayer/libswscale/Makefile	2006-07-04 11:05:14.000000000 +0200
> > @@ -1,52 +1,22 @@
> > -
> > +#
> > +# libswscale Makefile
> > +#
> 
> Hmm, not strictly necessary, some of the libav* Makefiles have it, some
> don't.  I'd leave it out as redundant, but I don't really care.
Ok, removed

> > +# NOTE: -I.. is needed to include config.h
> > +CFLAGS=$(OPTFLAGS) -I.. -I$(SRC_PATH) -I$(SRC_PATH)/libavutil -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_GNU_SOURCE
>  
> Please break this long line into a few more manageable pieces.
Done

> > +NAME=swscale
> > +ifeq ($(BUILD_SHARED),yes)
> > +LIBVERSION=$(LAVUVERSION)
> > +LIBMAJOR=$(LAVUMAJOR)
> >  endif
> 
> Please move this to the top of the Makefile, I prefer it to be there.
Moved

> Also, there should be a proper version for libswscale,
> right now you are just hijacking the version from libavutil.
Ops... Sorry, that was a typo. Since I've been told that libswscale does
not build as a dynamic library, I never tested that code. I put it there
for consistency with the libav* libraries, and to be ready when
libswscale will be ready to build as a .so ;-)


Anyway, I hope I addressed all the problems. New version of the patch
attached.

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

-------------- next part --------------
A non-text attachment was scrubbed...
Name: build.diff
Type: text/x-patch
Size: 2110 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060706/ef6e4f8b/attachment.bin>