[Ffmpeg-devel] Re: [PATCH] Fix/Allow cross compilation on Mac OS X with latest development tools

[Derk-Jan Hartman]

On 7-jul-2006, at 2:37, Patrice Bensoussan wrote:
> >On Tue, Jul 04, 2006 at 11:27:02PM +0100, Patrice Bensoussan wrote:
> >>
> >> Here is a second version of the patch which fixes a few issues.
> >> Anyone willing to apply?
>
> >I've rejected the patch once and you have failed to answer any of my
> >points, plus your newest patch *still* does not apply.
>
> >It will stay rejected until you fix both these issues, so please  
> don't
> >bother us with new incarnations of this thing until you have  
> addressed
> >them.
>
> >Diego
>
> First, my newest patch was sent on July 4 and was definitely working.
> If you apply the patch 3 days later, I don't see how I can prevent  
> other patches from breaking it.
>
> Second, here are some further info about why this patch is needed:
> To cross compile on Mac OS X, you need to pass -isysroot when  
> compiling *AND* when linking.
>
> The issue is that is you pass it to both --extra-ldflags and -- 
> extra-cflags gcc will complain whenever both CFLAGS and LDFLAGS are  
> passed at the same time (like in configure). That's why I added a -- 
> extra-commong-flags which can be used for flags required for both  
> and which cannot be duplicated on the command line.
>
> This is really helpful to cross compile and then generate an  
> universal binary with lipo.
>
> Please let me know if I should spend some time to update the patch,  
> or if you will reject it anyway.
>
> Patrice

Why not split out the compile and linking fase of these few locations  
that have the compile and linking flags combined?
Its little overhead, doesn't affect the readability of the Makefiles  
and doesn't introduce extra complexity that is confusing. The  
affected ffmpeg areas must be disabled in VLC, because I have no such  
issue on the VLC 10.3 SDK build.

Just a thought,
DJ

BTW. please search the archive for previous mac intel, cross compile  
and universal patches. there have been submitted several. And the  
fact that no one cleaned any of them up to ffmpeg-commit status,  
doesn't mean they were useless and didn't solve or indicate much of  
the issues you might potentially have to trace. No reason to do that  
twice.

[PATCH] Universal binary support for Mac OS X --> Dan Villiom  
Podlaski Christiansen 4 februari 2006
[PATCH] Fixes for Darwin/x86 --> Dan Villiom Podlaski Christiansen 6  
februari 2006
[patch] OS X Intel support -> Sam Hocevar 16 februari 2006
[patch] Darwin shared object support -> Sam Hocevar 16 februari 2006
[PATCH] Support universal binary compilation on Mac OS X --> Dan  
Villiom Podlaski Christiansen 24 februari 2006
[PATCH] Intel Mac MMX/SSE2 support --> roine gustafsson 30 june 2006

DJ