[Ffmpeg-devel] Re: [PATCH] Fix/Allow cross compilation on Mac OS X with latest development tools

[Diego Biurrun]

On Fri, Jul 07, 2006 at 01:37:29AM +0100, Patrice Bensoussan wrote:
> >On Tue, Jul 04, 2006 at 11:27:02PM +0100, Patrice Bensoussan wrote:
> >>
> >> Here is a second version of the patch which fixes a few issues.
> >> Anyone willing to apply?
> 
> >I've rejected the patch once and you have failed to answer any of my
> >points, plus your newest patch *still* does not apply.
> 
> >It will stay rejected until you fix both these issues, so please don't
> >bother us with new incarnations of this thing until you have addressed
> >them.
> 
> First, my newest patch was sent on July 4 and was definitely working.
> If you apply the patch 3 days later, I don't see how I can prevent  
> other patches from breaking it.

Depending on your timezone it was sent on July 5.  In any case I replied
to it after 25 hours.  That's one day, not three, in my book.

> Second, here are some further info about why this patch is needed:
> To cross compile on Mac OS X, you need to pass -isysroot when  
> compiling *AND* when linking.

Nothing stops you from adding -isysroot to both --extra-cflags and
--extra-ldflags, does it?

> The issue is that is you pass it to both --extra-ldflags and --extra- 
> cflags gcc will complain whenever both CFLAGS and LDFLAGS are passed  
> at the same time (like in configure). That's why I added a --extra- 
> commong-flags which can be used for flags required for both and which  
> cannot be duplicated on the command line.

How does gcc complain?

> This is really helpful to cross compile and then generate an  
> universal binary with lipo.
> 
> Please let me know if I should spend some time to update the patch,  
> or if you will reject it anyway.

If you keep omitting details I will keep rejecting it.  If you wish to
get this reconsidered you need to provide

- a clear and detailed description of the problem, not just "gcc
  complains" or "it does not work otherwise"
- a patch that applies cleanly

Diego

P.S.: Your mailer apparently breaks threads.  Please fix it or go look
for a better one.