[Ffmpeg-devel] [PATCH] imc should use av_log2

[Benjamin Larsson]

Reimar D?ffinger wrote:

>Hello,
>On Fri, Nov 10, 2006 at 05:56:37PM +0100, Benjamin Larsson wrote:
>  
>
>>I have sent a patch that fixed the issues but no one cared to review it. 
>> I'll apply it later.
>>    
>>
>
>You only asked if it fixes the problem and not for review. But as an
>absolute minimum comments must be added that explain those constants.
>  
>

Well there where no comments in the original code.

>Also as I understood Michael's comments adding a configure-based
>workaround that defines log2 if needed is the desired solution.
>  
>

Well IMO one instance of log2 in a long forgotten codec does not warrent
that.

>Greetings,
>Reimar D?ffinger
>

MvH
Benjamin Larsson

-- 
new tiny signature