[Ffmpeg-devel] [PATCH] imc should use av_log2

Reimar Döffinger Reimar.Doeffinger
Fri Nov 10 20:50:50 CET 2006


Hello,
On Fri, Nov 10, 2006 at 08:46:53PM +0100, Benjamin Larsson wrote:
> >You only asked if it fixes the problem and not for review. But as an
> >absolute minimum comments must be added that explain those constants.
> 
> Well there where no comments in the original code.

Of course there are no comments to explain that
log2(10) * 0.25
is log2(10) * 0.25 since that's obvious.
But it is less that obvious that
0.8304... is log2(10) * 0.25.

Greetings,
Reimar D?ffinger




More information about the ffmpeg-devel mailing list