[Ffmpeg-devel] [PATCH] VQA enhancements
Mike Melanson
mike
Tue Nov 28 07:03:51 CET 2006
Kostya wrote:
> Here is my old set of patches refreshed to be used with current SVN:
> vqa.version1.patch - VQA version 1 support
> (The Legend of Kyrandia III videos)
>
> vqa.demuxer.patch - changes in VQA demuxer which allow proper demuxing
> of v1 files (ignoring unknown chunks, some additional chunk support).
I would have no problem with you taking over maintenance of the VQA
system. However, at least one issue...
> - if (ret != chunk_size) {
> - ret = AVERROR_IO;
> - }
> + if (chunk_type == SND2_TAG) {
> + pkt->stream_index = wsvqa->audio_stream_index;
This smells like hard tabs. I see this all over the patch. Bad. Fix.
--
-Mike Melanson
More information about the ffmpeg-devel
mailing list