[Ffmpeg-devel] [PATCH] VQA enhancements

[Kostya]

On Mon, Nov 27, 2006 at 10:03:51PM -0800, Mike Melanson wrote:
> Kostya wrote:
> >Here is my old set of patches refreshed to be used with current SVN:
> >vqa.version1.patch - VQA version 1 support
> >(The Legend of Kyrandia III videos)
> >
> >vqa.demuxer.patch - changes in VQA demuxer which allow proper demuxing
> >of v1 files (ignoring unknown chunks, some additional chunk support).
> 
> I would have no problem with you taking over maintenance of the VQA 
> system. However, at least one issue...
> 
> >-        if (ret != chunk_size) {
> >-            ret = AVERROR_IO;
> >-        }
> >+            if (chunk_type == SND2_TAG) {
> >+                pkt->stream_index = wsvqa->audio_stream_index;
> 
> This smells like hard tabs. I see this all over the patch. Bad. Fix.

Not quite right - new code has chunks read in while() loop, hence
additional ident level.

Committed as is.

> -- 
> 	-Mike Melanson
>