[Ffmpeg-devel] [PATCH] indentation cosmetics

Diego Biurrun diego
Mon Sep 4 17:06:33 CEST 2006


On Mon, Sep 04, 2006 at 02:46:12PM +0200, Michel Bardiaux wrote:
> 
> But that means I now have a choice of indenting by hand, or of checking 
> every patch for changes that affect indentation only. What a waste of 
> time.

If you don't "waste your time" by checking your patches for stray
cosmetic changes I can assure you that I will not waste my time doing
this while reviewing your patches anymore.  I'll send them straight to
/dev/null, thus saving everybody's time.  Fair trade?

> Does rule 3 (no change) apply even when there is *functionality* 
> change in the line.

No, feel free to reindent lines that you are changing anyway, assuming
that it does not mess up surrounding indentation.

Diego





More information about the ffmpeg-devel mailing list