[Ffmpeg-devel] [PATCH] indentation cosmetics
Michel Bardiaux
mbardiaux
Mon Sep 4 17:10:44 CEST 2006
Diego Biurrun wrote:
> On Mon, Sep 04, 2006 at 02:46:12PM +0200, Michel Bardiaux wrote:
>> But that means I now have a choice of indenting by hand, or of checking
>> every patch for changes that affect indentation only. What a waste of
>> time.
>
> If you don't "waste your time" by checking your patches for stray
> cosmetic changes I can assure you that I will not waste my time doing
> this while reviewing your patches anymore. I'll send them straight to
> /dev/null, thus saving everybody's time. Fair trade?
No, but since this is the only game in town...
>
>> Does rule 3 (no change) apply even when there is *functionality*
>> change in the line.
>
> No, feel free to reindent lines that you are changing anyway, assuming
> that it does not mess up surrounding indentation.
>
> Diego
>
--
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be
Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/
More information about the ffmpeg-devel
mailing list