[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

[Baptiste COUDURIER]

Hi

Gustavo Sverzut Barbieri wrote:
> Hello,
> 
> I did write vhook/drawtext.c once and I've being using it since then.
> 
> However it had some bugs, which some users already reported to me in
> private... so I rewrote it yesterday, in a clever way... you know,
> developers do learn ;-)
> 
> Patch is attached, please consider.
> 
> Comments are always welcome!

Nice to hear. I'll test functionnality soon.

> [...]
>  
>  #define MAXSIZE_TEXT 1024
> +#define _XOPEN_SOURCE 600

What is that define needed for ?

> [...]
> -}
> +static void
> +err(const char *fmt, ...)
> +{
> +    va_list args;
>  
> +    fputs("drawtext: ERROR: ", stderr);
>  
> +    va_start(args, fmt);
> +    vfprintf(stderr, fmt, args);
> +    va_end(args);

Please use av_log instead of fputc, etc. Also, av_log supports
AV_LOG_ERROR, AV_LOG_INFO, ...

I did not review everything, it seems a lot of code has been moved
around the file. Could you please replace them back so the code will be
easier to review ?

And why are the Makefile changes needed ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312