[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

[Gustavo Sverzut Barbieri]

On 9/4/06, Baptiste COUDURIER <baptiste.coudurier at smartjog.com> wrote:
> Hi
>
> Gustavo Sverzut Barbieri wrote:
> > Hello,
> >
> > I did write vhook/drawtext.c once and I've being using it since then.
> >
> > However it had some bugs, which some users already reported to me in
> > private... so I rewrote it yesterday, in a clever way... you know,
> > developers do learn ;-)
> >
> > Patch is attached, please consider.
> >
> > Comments are always welcome!
>
> Nice to hear. I'll test functionnality soon.
>
> > [...]
> >
> >  #define MAXSIZE_TEXT 1024
> > +#define _XOPEN_SOURCE 600
>
> What is that define needed for ?

posix_fadvise() and possible others defined on later posix standard
(not c90/99).


> > [...]
> > -}
> > +static void
> > +err(const char *fmt, ...)
> > +{
> > +    va_list args;
> >
> > +    fputs("drawtext: ERROR: ", stderr);
> >
> > +    va_start(args, fmt);
> > +    vfprintf(stderr, fmt, args);
> > +    va_end(args);
>
> Please use av_log instead of fputc, etc. Also, av_log supports
> AV_LOG_ERROR, AV_LOG_INFO, ...

I'll do it.


> I did not review everything, it seems a lot of code has been moved
> around the file. Could you please replace them back so the code will be
> easier to review ?

I don't think it will help that much, maybe is better to review it as
a new file instead.


> And why are the Makefile changes needed ?

so it doesn't link other hooks with freetype2.


-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: barbieri at gmail.com
   MSN: barbieri at gmail.com
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
 Phone:  +1 (347) 624 6296; 08122692 at sip.stanaphone.com
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net