[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

[Diego Biurrun]

On Wed, Sep 06, 2006 at 11:22:04AM -0300, Gustavo Sverzut Barbieri wrote:
> On 9/6/06, Diego Biurrun <diego at biurrun.de> wrote:
> >On Wed, Sep 06, 2006 at 10:13:19AM -0300, Gustavo Sverzut Barbieri wrote:
> >>
> >> --- vhook/Makefile    (revision 6179)
> >> +++ vhook/Makefile    (working copy)
> >> @@ -35,7 +35,7 @@
> >>
> >>  %$(SLIBSUF): %.o
> >> -     $(CC) $(LDFLAGS) -g -o $@ $(VHOOKSHFLAGS) $<
> >> +     $(CC) $(LDFLAGS_$@) $(VHOOKLIBS) $(LDFLAGS) -g -o $@ 
> >$(VHOOKSHFLAGS) $<
> >
> >Why do you add $(VHOOKLIBS) here?
> 
> it was a remaining from tests with cygwin patch.
> 
> before I sent another patch with just this fix, do you really require
> incremental patches? It will take me some time and as I said, it's
> better to review the new code instead of changes. But if really
> required I can do :-)

I'm not quite sure what you mean by incremental here.  In any case the
build system part is separate from the rest of the patch.  Split it off,
I'll apply it.

> Thanks for keeping the high quality! :-)

:-)

Diego