[Ffmpeg-devel] [PATCH] rewrite vhook/drawtext.c

[Gustavo Sverzut Barbieri]

On 9/6/06, Diego Biurrun <diego at biurrun.de> wrote:
> On Wed, Sep 06, 2006 at 11:22:04AM -0300, Gustavo Sverzut Barbieri wrote:
> > On 9/6/06, Diego Biurrun <diego at biurrun.de> wrote:
> > >On Wed, Sep 06, 2006 at 10:13:19AM -0300, Gustavo Sverzut Barbieri wrote:
> > >>
> > >> --- vhook/Makefile    (revision 6179)
> > >> +++ vhook/Makefile    (working copy)
> > >> @@ -35,7 +35,7 @@
> > >>
> > >>  %$(SLIBSUF): %.o
> > >> -     $(CC) $(LDFLAGS) -g -o $@ $(VHOOKSHFLAGS) $<
> > >> +     $(CC) $(LDFLAGS_$@) $(VHOOKLIBS) $(LDFLAGS) -g -o $@
> > >$(VHOOKSHFLAGS) $<
> > >
> > >Why do you add $(VHOOKLIBS) here?
> >
> > it was a remaining from tests with cygwin patch.
> >
> > before I sent another patch with just this fix, do you really require
> > incremental patches? It will take me some time and as I said, it's
> > better to review the new code instead of changes. But if really
> > required I can do :-)
>
> I'm not quite sure what you mean by incremental here.

like the linux kernel guys like, something like "[PATCH 0/N] replace
macros with inline functions" "[PATCH 1/N] ..."

I can do that, but it's a lot of work we don't need now.


>  In any case the
> build system part is separate from the rest of the patch.  Split it off,
> I'll apply it.

Ok, it's posted on a new thread.

-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: barbieri at gmail.com
   MSN: barbieri at gmail.com
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
 Phone:  +1 (347) 624 6296; 08122692 at sip.stanaphone.com
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net