[Ffmpeg-devel] [PATCH] wrong use of ff_get_fourcc in mpjg.c

[Michael Niedermayer]

Hi

On Wed, Feb 07, 2007 at 11:18:07AM +0100, Reimar Doeffinger wrote:
> Hello,
> attached patch fixes bug 739 by using the much more obvious to
> understand MKBETAG.

ok


> I think this is not the first bug of this kind caused by this functions,
> indicating it that it is flawed in so far as it has non-obvious
> semantics, so may I suggest deprecating it?

what about replacing all
MK*TAG and ff_get_fourcc by

AV_RB32("ABCD") / AV_RL32("ABCD") ?

assuming of course that the compiler can optimize this into similarely
simple code ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070207/41927e41/attachment.pgp>