[Ffmpeg-devel] [PATCH] wrong use of ff_get_fourcc in mpjg.c

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Wed, Feb 07, 2007 at 11:18:07AM +0100, Reimar Doeffinger wrote:
>> Hello,
>> attached patch fixes bug 739 by using the much more obvious to
>> understand MKBETAG.
> 
> ok
> 
> 
>> I think this is not the first bug of this kind caused by this functions,
>> indicating it that it is flawed in so far as it has non-obvious
>> semantics, so may I suggest deprecating it?
> 
> what about replacing all
> MK*TAG and ff_get_fourcc by
> 
> AV_RB32("ABCD") / AV_RL32("ABCD") ?
> 
> assuming of course that the compiler can optimize this into similarely
> simple code ...
> 

I like MKTAG, which illustrates that we are looking for a tag rather
than a serie of bytes. MKTAG("ABCD") would be nice though.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312