[Ffmpeg-devel] Re: [PATCH] FFmpeg theora encoding

[Paul Richards]

Here are the file rename, whitespace, and ordering changes you requested.


On 07/01/07, Diego Biurrun <diego at biurrun.de> wrote:
> On Sun, Jan 07, 2007 at 08:54:13PM +0000, Paul Richards wrote:
> > On 07/01/07, Paul Richards <paul.richards at gmail.com> wrote:
> > >After taking in the various comments given here is the revised patch.
> > >Perhaps it can be considered for committing.
> > >
> > >Unfortunately the VLC playback problem remains but I cannot yet
> > >identify the source of the problem.  Hopefully this can be resolved in
> > >a followup commit.
> >
> > Here is another attempt.  This time I have refactored code which
> > checks libtheora return values.
> >
> > Hopefully this one is good enough to commit? :p
>
> You still have trailing whitespace in the file and it has not been
> renamed to libtheoraenc yet.  Also, please respect alphabetical order in
> the configure script.
>
> Diego
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> http://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel
>


-- 
Paul Richards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: theora.patch
Type: application/octet-stream
Size: 13571 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070108/cda60161/attachment.obj>