[Ffmpeg-devel] Re: [PATCH] FFmpeg theora encoding

[Diego Biurrun]

Please don't top-post.

On Mon, Jan 08, 2007 at 09:20:19AM +0000, Paul Richards wrote:
> 
> On 07/01/07, Diego Biurrun <diego at biurrun.de> wrote:
> >On Sun, Jan 07, 2007 at 08:54:13PM +0000, Paul Richards wrote:
> >> On 07/01/07, Paul Richards <paul.richards at gmail.com> wrote:
> >> >After taking in the various comments given here is the revised patch.
> >> >Perhaps it can be considered for committing.
> >> >
> >> >Unfortunately the VLC playback problem remains but I cannot yet
> >> >identify the source of the problem.  Hopefully this can be resolved in
> >> >a followup commit.
> >>
> >> Here is another attempt.  This time I have refactored code which
> >> checks libtheora return values.
> >>
> >> Hopefully this one is good enough to commit? :p
> >
> >You still have trailing whitespace in the file and it has not been
> >renamed to libtheoraenc yet.  Also, please respect alphabetical order in
> >the configure script.
> 
> Here are the file rename, whitespace, and ordering changes you requested.

Trailing whitespace is still there.  Please call the configure option
--enable-libtheora.  Also, I reordered libavcodec/Makefile and put the
external libraries in a separate block, libtheora should go there.

The following block is an independent change that should go in right
away I think:

--- libavcodec/vp3.c	(revision 7422)
+++ libavcodec/vp3.c	(working copy)
@@ -2643,7 +2643,6 @@
 
-#ifndef CONFIG_LIBTHEORA
 AVCodec theora_decoder = {
     "theora",
     CODEC_TYPE_VIDEO,
@@ -2656,4 +2655,3 @@
     0,
     NULL
 };
-#endif

I've committed it.

Diego