[FFmpeg-devel] [PATCH] Mention unneeded casts and parenthesis in Coding Rules (doc)

Benoit Fouet benoit.fouet
Wed Jun 27 08:46:58 CEST 2007


Vitor wrote:
> Hi,
>
> Since these two things show up very frequently when reviewing patches,
> I think they are worth a mention in the documentation.
>
> Warning: I'm a non native english speaker!
>
> -Vitor
> ------------------------------------------------------------------------
>
> Index: doc/ffmpeg-doc.texi
> ===================================================================
> --- doc/ffmpeg-doc.texi	(revision 9440)
> +++ doc/ffmpeg-doc.texi	(working copy)
> @@ -1539,6 +1539,9 @@
>  fprintf and printf are forbidden in libavformat and libavcodec,
>  please use av_log() instead.
>  
> +Ideally, casts should be used only when necessary. Unneeded parenthesis
> +should also be avoided if they don't make the code easier to understand.
> +
>   

i think plural is parentheses

Ben
-- 
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list