[FFmpeg-devel] [PATCH] Mention unneeded casts and parenthesis in Coding Rules (doc)

[Måns Rullgård]

Benoit Fouet <benoit.fouet at purplelabs.com> writes:

> Vitor wrote:
>> Hi,
>>
>> Since these two things show up very frequently when reviewing patches,
>> I think they are worth a mention in the documentation.
>>
>> Warning: I'm a non native english speaker!
>>
>> -Vitor
>> ------------------------------------------------------------------------
>>
>> Index: doc/ffmpeg-doc.texi
>> ===================================================================
>> --- doc/ffmpeg-doc.texi	(revision 9440)
>> +++ doc/ffmpeg-doc.texi	(working copy)
>> @@ -1539,6 +1539,9 @@
>>  fprintf and printf are forbidden in libavformat and libavcodec,
>>  please use av_log() instead.
>>  
>> +Ideally, casts should be used only when necessary. Unneeded parenthesis
>> +should also be avoided if they don't make the code easier to understand.
>> +
>>   
>
> i think plural is parentheses

It is.  I'd also drop the "ideally".  An unnecessary cast is a bug.
Actually, a necessary cast is also often a bug.

-- 
M?ns Rullg?rd
mans at mansr.com