[FFmpeg-devel] [PATCH 5/6] rmdec.c: move around rm_ac3_swap_bytes()

Ronald S. Bultje rsbultje
Wed Nov 14 00:39:33 CET 2007


Hi Roberto,

On Nov 13, 2007 2:55 PM, Roberto Togni <rxt at rtogni.it> wrote:

> This breaks support for old ra files, you need to call the ac3
> reordering function also in the old_format code path.
> Also calling the reordering code in the cache function is useless,
> since dnet does not use a descrambling matrix.


May I suggest adding a comment in the cache function or in the read_frame()
function after retrieve_cache() such that this is clear to future ignorant
people like me?

Ronald




More information about the ffmpeg-devel mailing list