[FFmpeg-devel] [PATCH 5/6] rmdec.c: move around rm_ac3_swap_bytes()

[Roberto Togni]

On Tue, 13 Nov 2007 20:55:23 +0100
Roberto Togni <rxt at rtogni.it> wrote:

> On Tue, 13 Nov 2007 09:32:22 -0500
> "Ronald S. Bultje" <rsbultje at gmail.com> wrote:
> 
> > Hi,
> > 
> > On Nov 8, 2007 10:03 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > 
> > > On Thu, Nov 08, 2007 at 10:48:36AM -0500, Ronald S. Bultje wrote:
> > > > On Nov 5, 2007 3:28 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > > > > as mentioned in 4/6, ac3_swap_bytes() would ideally be called higher
> > > up,
> > > > > such that the RTP parsing code does not need to call or swap bytes
> > > > > explicitely itself. This patch does exactly that.
> > > >
> > > > Anyone want to review this one? It's the last rmdec-related one, at
> > > least
> > > > for the function refactoring.
> > >
> > > ill leave this one to roberto, iam not sure about it
> > 
> > 
> > Roberto, ping?
> > 
> 
> Not ok.
> 
> This breaks support for old ra files, you need to call the ac3
> reordering function also in the old_format code path.
> Also calling the reordering code in the cache function is useless,
> since dnet does not use a descrambling matrix.
> 
> Try attached patch
> 
Applied something similar

Ciao,
 Roberto

-- 
Better is the enemy of good enough.