[FFmpeg-devel] [RFC] Split libavformat
Luca Abeni
lucabe72
Wed Nov 21 18:01:50 CET 2007
Hi Michael,
Michael Niedermayer wrote:
[...]
>> +#define LIBAVDEVICE_IDENT "Lavd" AV_STRINGIFY(LIBAVDEVICE_VERSION)
>
> unused, please remove
>
>
> [...]
>> +/**
>> + * Initialize libavdevice and register all the (de)muxers.
>> + */
>> +void avdevice_register_all(void)
>> +{
>> + static int inited;
>> +
>> + if (inited)
>> + return;
>> + inited = 1;
>
> you should at the very least mention that this is not thread safe in the
> comment
>
> also doxy should be in the public header preferably instead of teh c file
Sorry, I missed this part of your email when I read it (I was in hurry and
I closed the email too early)... Tomorrow I'll update the patches according
to this feedback.
Thanks,
Luca
More information about the ffmpeg-devel
mailing list