[FFmpeg-devel] [PATCH] Fix redirector implementation

[Luca Abeni]

Hi Michael,

thanks for your comments.

Michael Niedermayer wrote:
[...]
>> Even if we decide not to split libavnet, I believe this patch is useful
>> (at least, it fixes an "XXX: " comment)...
>> If there is something wrong with it, I am willing to fix it; just let me
>> know.
> 
> i think:
> 
> memleak on close

I initially used a "close" method calling av_close_input_file(), but I got
a double-free error, so I removed it. I am sure I did something wrong, and
I am going to double-check it...


> metadata author, ... wont be passed (also a solution to this should not fail
> if more metadata fields get added)

I did not think about metadata & friends... Going to see how to properly handle
them.
I am thinking about a more radical approach: basically, doing a
*s = *ic;
at the end of redir_read_header()... Do you see any obvious problems with it?
I am going to test this idea, and will send a patch this afternoon.


			Thanks,
				Luca