[FFmpeg-devel] [PATCH] Fix redirector implementation

[Michael Niedermayer]

On Wed, Nov 28, 2007 at 09:37:48AM +0100, Luca Abeni wrote:
> Hi Michael,
> 
> thanks for your comments.
> 
> Michael Niedermayer wrote:
> [...]
> >> Even if we decide not to split libavnet, I believe this patch is useful
> >> (at least, it fixes an "XXX: " comment)...
> >> If there is something wrong with it, I am willing to fix it; just let me
> >> know.
> > 
> > i think:
> > 
> > memleak on close
> 
> I initially used a "close" method calling av_close_input_file(), but I got
> a double-free error, so I removed it. I am sure I did something wrong, and
> I am going to double-check it...
> 
> 
> > metadata author, ... wont be passed (also a solution to this should not fail
> > if more metadata fields get added)
> 
> I did not think about metadata & friends... Going to see how to properly handle
> them.
> I am thinking about a more radical approach: basically, doing a
> *s = *ic;
> at the end of redir_read_header()... Do you see any obvious problems with it?

no but that doesnt say much, there still could be obvious problems :)


> I am going to test this idea, and will send a patch this afternoon.

ok


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071128/c59c9359/attachment.pgp>