[FFmpeg-devel] Collection of patches

[Diego Biurrun]

On Thu, Apr 24, 2008 at 01:48:27PM +0200, Thorsten Jordan wrote:
> Benoit Fouet schrieb:
> > Thorsten Jordan wrote:
> >> sorry, my mistake, here is a version with all things fixed, it compiles
> >> also (should have checked before)
> >>
> >> +    /* Pixel aspect ratio setting */
> >> +    if (avctx->sample_aspect_ratio.num < 1 || avctx->sample_aspect_ratio.num > 255 ||
> >> +        avctx->sample_aspect_ratio.den < 1 || avctx->sample_aspect_ratio.den > 255) {
> >> +        av_log(avctx, AV_LOG_ERROR, "Invalid pixel aspect ratio %i/%i\n",
> >> +            avctx->sample_aspect_ratio.num, avctx->sample_aspect_ratio.den);
> >> +            return -1;
> >>   
> > 
> > weird indentation
> how would you like it to be? "||" on next line? second line indented
> less than four?

The comment refers to the av_log, which could be indented better:

+        av_log(avctx, AV_LOG_ERROR, "Invalid pixel aspect ratio %i/%i\n",
+               avctx->sample_aspect_ratio.num, avctx->sample_aspect_ratio.den);

Diego